-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix broken snappy support in leveldb #276
Fix broken snappy support in leveldb #276
Conversation
Without exporting the compiling flags the build_detect_platform is not able to detect the snappy support and does not set the SNAPPY C macro.
@martinsumner how could we proceed with this. |
I wanted to have a test to make sure if we do fix this issue, we're not going to regress the fix. This updated riak_test upgrade test detects both the problem of compression not working, as well as the previously undetected issue of snappy updates being uncompatable. However, when I test this on a non-update (e.g. previous and current both
So I can't seem to get this PR to resolve the problem. Is there other evidence this works? |
@tburghart is there a fix for this in your version? |
As per basho#276
Previously when I tested this fix, using the updated verify_basic_upgrade - it FAILED. But this was testing on my OSX laptop. I tried this fix today on Ubuntu - and it worked.
This would appear to confirm this PR is good on Ubuntu. The original issue is caused by snappy not running and not due to incompatibility between 1.0.4 and 1.1.9. As OSX is not supported for running production Riak clusters, I think the PR should be accepted so that there can be a 3.0.17 release that will allow multi_backend users (or those who have over-ridden the LZ4 default) to safely upgrade from 3.0.11. @nsaadouni - is this something you can look at? |
The OSX issues can be resolved by setting "std=c++11" in the CFLAGS and COMMON_FLAGS in build_detect_platform: Also in the rebar.config.script so that it is used when compiling eleveldb: nhs-riak@50dd137#diff-a07a3d3b357a34c4acb80b2e178e9a19e6c2ed9d91cb0aa8d53cadabb1ae8bd0 |
Sorry for being late to the discussion.
This has given us not only a clean build across platforms, but also a tree that recognizes it's already been built so it doesn't rebuild 8 times when making devrels 🤨 |
Without exporting the compiling flags the build_detect_platform is not able to detect the snappy support and does not set the SNAPPY C macro.
Fix issue #275