Mv tuning6 #96
Merged
Mv tuning6 #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| {mapping, "leveldb.block_cache_threshold", "eleveldb.block_cache_threshold", [ | ||
| {default, "16MB"}, | ||
| {datatype, bytesize}, | ||
| {level, advanced} |
There was a problem hiding this comment.
{level, advanced} is deprecated, use hidden instead.
There was a problem hiding this comment.
Corrected. And pushed to origin.
On Feb 13, 2014, at 2:26 PM, Sean Cribbs notifications@github.com wrote:
In priv/eleveldb.schema:
@@ -134,6 +134,23 @@
{level, advanced}
]}.+%% @doc Defines the limit where block cache memory can no longer be
+%% released in favor of the page cache. This has no impact with
+%% regard to release in favor of file cache. The value is per
+%% vnode.
+{mapping, "leveldb.block_cache_threshold", "eleveldb.block_cache_threshold", [
- {default, "16MB"},
- {datatype, bytesize},
- {level, advanced}
{level, advanced} is deprecated, use hidden instead.—
Reply to this email directly or view it on GitHub.
|
code is good. tests pass. 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detail description here: https://github.com/basho/leveldb/wiki/mv-tuning6
This branch requires manual pull of leveldb's mv-tuning6 branch to compile.
Adds block_cache_threshold parameter to options interfaces. Corrects an incorrect type on m_TotalMem member of EleveldbOptions structure.