Include pthread.h and time.h to get leveldb to build on FreeBSD 10 #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current leveldb codebase, using the latest gcc and g++ compilers, does not build successfully in FreeBSD 10. One will see errors such as: ./util/cache2.h:74:5: error: unknown type name 'time_t' or ./include/leveldb/env.h:373:13: error: incomplete result type 'pthread' in function definition Including the POSIX time.h and pthread.h header files yields a successful build on FreeBSD 10.x releases.
|
Ping. Related to basho/riak#496, but these changes are needed to get it to compile. |
|
+1 d67605d |
matthewvon
added a commit
that referenced
this pull request
Jul 30, 2015
fred tested ... says warnings still exist in FreeBSD 10
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current leveldb codebase, using the latest gcc and g++ compilers,
does not build successfully in FreeBSD 10. One will see errors such as:
./util/cache2.h:74:5: error: unknown type name 'time_t'
or
./include/leveldb/env.h:373:13: error: incomplete result type 'pthread'
in function definition
Including the POSIX time.h and pthread.h header files yields a
successful build on FreeBSD 10.x releases.