Improve dialyzer types and checking #369
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
January 30, 2018 18:04
Many of the functions defined in riakc_pb_socket have specs that say they take a pid(), but they in fact just pass this argument to gen_server:call so they can take any ServerName argument that gen_server:call accepts.
The #state.credentials field is declared as {User::string(),
Password::string()} but the rpbauthreq record's user and password
fields are declared as binary. Call iolist_to_binary to convert.
Dialzyer produces errors such as the following because the code checks for fields containing `undefined` when the spec does not allow it. riakc_pb_socket.erl:1786: The pattern 'undefined' can never match the type [binary()]
dhull
force-pushed
the
more-lenient-pid-type
branch
from
8d42c07
to
c3f2979
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request has three commits.
The first changes the specs for some riak_pb_socket to allow an atom (for a registered name) as an alternative to passing the pid.
The second and third are to get rid of the warnings produced by "make lint". In the second, some values that were declared as string were copied to record fields that were declared to accept only binary; I added a
iolist_to_binaryconversion to silence that warning. In the third, some code is testing for anundefinedvalue for record fields that are declared to not allowundefined; I diabled dialyzer's no_match warning for that function.