Riak 2 Feature: Security

[bkerley]

The Ruby client needs to support security per basho/riak#355 .

• configure local and tls credentials

c = Riak::Client.new(
                     pb_port: 17017,
                     authentication: {
                       user: 'user',
                       password: 'password',
                       server_ca: File.read('ca.crt'),
                       server_cert: File.read('server.crt')
                     }
                    )

• upgrade a protobuffs connection to tls
• kill the connection if the server doesn't have a valid cert
• kill the connection if the server doesn't support tls
• kill the conncetion if the server's cert is revoked
• work correctly when requests succeed

(copied from #110 )

[seancribbs]

I worry that these tests basically describe an implementation (too many doubles). Is there a way to exercise the class at a higher level, or more like blackbox? Integration tests are fine.

Another option might be like the "mock server" we had previously where it would actually create a server-side version and you could verify what came across the wire.

You can also tell me to buzz off. 😁

[bkerley]

Yeah, there's already an integration test that hits these parts. The problem with those is that they require many different Riak configurations, and right now that means they basically don't get run on a regular basis. I'd prefer to keep these as a safety net, and I'm not sure if there's a much better way to express these.

[bkerley]

• put server cert in crl for pending spec
• make other specs pass

[seancribbs]

This works as advertised when using this PR to riak-ruby-vagrant: basho-labs/riak-ruby-vagrant#4

👍