Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Remove - flag from su in riak startup script #1075

Open
wants to merge 1 commit into
base: develop-3.0
Choose a base branch
from

Conversation

jrogov
Copy link

@jrogov jrogov commented Jun 1, 2021

This is more of a request for comments than an actual PR.

Recently while tweaking our base image we've discovered that it's practically impossible to pass env variables (such as WAIT_FOR_ERLANG) from script.

I believe the reasons for this are the su lines with env passing turned off explicitly (via - aka -l flag) here:

As well as sud commands in node_package:

As a workaround, preliminary su to runner user (riak) in this case was used with passed env.

It left us wondering: was it done by purpose? Safety net of sorts to ensure safe environment?

@martinsumner
Copy link
Contributor

I'm the git blame for the first of those, and honestly I don't know. I suspect I've copied something across, rather than having a specific purpose.

@martincox, @yorkshire-steve - do you have any opinions on this?

@Bob-The-Marauder
Copy link
Contributor

Not sure if it's relevant but on the theme of waiting for Erlang, can you use riak-admin wait-for-service riak_kv riak@<nodeIP> as a work around? See https://www.tiot.jp/riak-docs/riak/kv/2.2.6/using/admin/riak-admin/#wait-for-service for details.

@martinsumner
Copy link
Contributor

#1088

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants