Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes are primarily about correcting the test conditions so that the target_n_val is set correctly, and that the number of nodes and n-vals used in the tests will consistently work - without there being a chance that sometimes a minority of nodes might contain a majority of partitions.
There is still an outstanding issue with ensemble_remove_node2 - basho/riak_core#943
There is still a very intermittent failure in
ensemble_sync
. Very rarely one of the PUTs will timeout https://github.com/basho/riak_test/blob/develop-2.9/tests/ensemble_sync.erl#L109-L110. It is not the first put. On one occasion it was associated with a vnode unexpectedly trying to handoff via raw_put and the bang returning a badarg.Note also - basho/riak#994