Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User comparison should be lowercase #59

Closed
M-Zuber opened this issue Sep 2, 2015 · 3 comments · Fixed by #60
Closed

User comparison should be lowercase #59

M-Zuber opened this issue Sep 2, 2015 · 3 comments · Fixed by #60
Labels
first-timers-only

Comments

@M-Zuber
Copy link
Collaborator

M-Zuber commented Sep 2, 2015

see here.

Related to #57

Places to fix:

Anywhere else the change should be added?
@basicallydan
Copy link
Owner

Not in anywhere that the user is concerned, nope - I can't find anything, anyway.

Alshie added a commit to Alshie/forkability that referenced this issue Sep 10, 2015
@Alshie
case insensitive comparison of login & username
3510e35 
fixes issue 59 basicallydan#59 by
doing case insensitive comarison of username to given login
This was referenced Sep 10, 2015
Open
Merged
@Alshie
Copy link

Alshie commented Sep 10, 2015

Hello,

I've submitted a pull request for this. First time I have ever been through this process so hopefully I have done correctly.

@M-Zuber
Copy link
Collaborator Author

M-Zuber commented Sep 10, 2015

So far you are doing great. 😄
I left you some feedback back at the PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
first-timers-only
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

case insensitive comparison of login & username Alshie/forkability
3 participants
@Alshie @basicallydan @M-Zuber