Are ignores still needed?

basil · Aug 26, 2024 · e176d4d · e176d4d
1 parent 7bb4aaf
commit e176d4d
Show file tree

Hide file tree

Showing 9 changed files with 2 additions and 32 deletions.
diff --git a/src/test/java/plugins/ArtifactoryPluginTest.java b/src/test/java/plugins/ArtifactoryPluginTest.java
@@ -28,7 +28,6 @@
 import org.jenkinsci.test.acceptance.po.Build;
 import org.jenkinsci.test.acceptance.po.FreeStyleJob;
 import org.jenkinsci.test.acceptance.po.JenkinsConfig;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.jvnet.hudson.test.Issue;
@@ -64,7 +63,7 @@ public void check_config_is_persisted() {
         waitFor(hasContent(Pattern.compile("Error occurred while requesting version information: Connection( to http://localhost:4898)* refused")));
     }
 
-    @Test @WithPlugins("maven-plugin") @Ignore @Issue("JENKINS-66791")
+    @Test @WithPlugins("maven-plugin") @Issue("JENKINS-66791")
     public void maven_integration() {
         MavenInstallation.installSomeMaven(jenkins);
         final ArtifactoryContainer artifactory = artifactoryContainer.get();
@@ -88,7 +87,7 @@ public void maven_integration() {
         assertThat(log, containsRegexp("Deploying build (info|descriptor) to: " + artifactory.getURL() + "/api/build"));
     }
 
-    @Test @WithPlugins("gradle") @Ignore @Issue("JENKINS-39323")
+    @Test @WithPlugins("gradle") @Issue("JENKINS-39323")
     public void gradle_integration() {
         final ArtifactoryContainer artifactory = artifactoryContainer.get();
         waitForArtifactory(artifactory);

diff --git a/src/test/java/plugins/GitLabPluginTest.java b/src/test/java/plugins/GitLabPluginTest.java
@@ -17,7 +17,6 @@
 import org.jenkinsci.test.acceptance.po.WorkflowJob;
 import org.jenkinsci.test.acceptance.po.WorkflowMultiBranchJob;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
@@ -109,7 +108,6 @@ public void init() throws InterruptedException, IOException {
     }
 
     @Test
-    @Ignore("https://github.com/jenkinsci/acceptance-test-harness/issues/1461")
     public void testGitLabMultibranchPipeline() throws IOException, GitLabApiException {
         createRepo();
 
@@ -160,8 +158,6 @@ public void testGitLabMultibranchPipeline() throws IOException, GitLabApiExcepti
         container.deleteRepo(getPrivateTokenAdmin(), repoName);
     }
 
-    // TODO: re-enable when flaky tests have been resolved. see: https://github.com/jenkinsci/acceptance-test-harness/pull/1365
-    @Ignore("flaky test")
     @Test
     public void gitLabGroupFolderOrganization() throws GitLabApiException, IOException {
         createGroup();

diff --git a/src/test/java/plugins/GitPluginTest.java b/src/test/java/plugins/GitPluginTest.java
@@ -44,7 +44,6 @@
 import org.jenkinsci.test.acceptance.po.GlobalSecurityConfig;
 import org.jenkinsci.test.acceptance.po.Job;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.openqa.selenium.By;
@@ -199,7 +198,6 @@ public void check_revision() {
     }
 
     @Test
-    @Ignore("Fails on CI for unknown reasons")
     public void update_submodules_recursively() {
         String name = "submodule";
         buildGitRepo()

diff --git a/src/test/java/plugins/JabberPluginTest.java b/src/test/java/plugins/JabberPluginTest.java
@@ -21,25 +21,12 @@
 import org.jenkinsci.test.acceptance.plugins.jabber.JabberPublisher;
 import org.jenkinsci.test.acceptance.plugins.jabber.JabberPublisher.Publishers;
 import org.jenkinsci.test.acceptance.po.FreeStyleJob;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 
-/**
- * This test case is set to @Ignore because the Jabber Plugin is not able to connect to conference.localhost
- * because DNS resolution issues. These issues arise because of the used Smack API
- *      (<a href="https://www.igniterealtime.org/projects/smack/index.jsp">Smack Documentation</a>)
- * that does rely on successful DNS resolution, which is totally valid in terms on conformity with the XMPP Standard.
- * <p>
- * This test is broken until a new version of the jabber plugin with a new Smack Library is provided that falls back to
- * using the hostname if the FQDN could not be resolved, *
- *
- * @author jenky-hm
- */
 @WithPlugins("jabber")
 @Category(DockerTest.class)
 @WithDocker
-@Ignore("TODO: Bring this back to life or remove from testsuite")
 public class JabberPluginTest extends AbstractJUnitTest {
     @Inject
     private DockerContainerHolder<JabberContainer> docker;

diff --git a/src/test/java/plugins/JobConfigHistoryPluginTest.java b/src/test/java/plugins/JobConfigHistoryPluginTest.java
@@ -37,12 +37,10 @@
 import org.jenkinsci.test.acceptance.po.FreeStyleJob;
 import org.jenkinsci.test.acceptance.po.MatrixProject;
 import org.jenkinsci.test.acceptance.po.ShellBuildStep;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.jvnet.hudson.test.Issue;
 
 @WithPlugins("jobConfigHistory")
-@Ignore("Flaky see issue 1052") //https://github.com/jenkinsci/acceptance-test-harness/issues/1052
 public class JobConfigHistoryPluginTest extends AbstractJUnitTest {
 
     private static final String LS_COMMAND = "ls";

diff --git a/src/test/java/plugins/MailWatcherPluginTest.java b/src/test/java/plugins/MailWatcherPluginTest.java
@@ -37,7 +37,6 @@
 import org.jenkinsci.test.acceptance.slave.SlaveController;
 import org.jenkinsci.test.acceptance.utils.mail.MailhogProvider;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.junit.experimental.categories.Category;
 import org.jvnet.hudson.test.Issue;
@@ -79,7 +78,6 @@ public void notify_slave_on_restart() throws Exception {
     }
 
     @Test @Issue("JENKINS-20538") @Since("1.571") @WithPlugins("mail-watcher-plugin")
-    @Ignore("Flaky test, passes sometimes on CI")
     public void notify_master_on_jenkins_restart() throws Exception {
         jenkins.configure();
         {

diff --git a/src/test/java/plugins/NodeLabelParameterPluginTest.java b/src/test/java/plugins/NodeLabelParameterPluginTest.java
@@ -19,7 +19,6 @@
 import org.jenkinsci.test.acceptance.plugins.textfinder.TextFinderPublisher;
 import org.jenkinsci.test.acceptance.po.*;
 import org.jenkinsci.test.acceptance.slave.SlaveController;
-import org.junit.Ignore;
 import org.junit.Test;
 import org.jvnet.hudson.test.Issue;
 import org.openqa.selenium.WebElement;
@@ -344,7 +343,6 @@ public void trigger_if_succeeds_with_failed_main_build() throws Exception {
     @Test
     @WithPlugins("text-finder")
     @Issue("JENKINS-23129")
-    @Ignore("Until JENKINS-23129 is fixed")
     public void trigger_if_succeeds_with_failed_post_build_step() throws Exception {
         FreeStyleJob j = jenkins.jobs.create();
 
@@ -398,7 +396,6 @@ public void trigger_if_succeeds_with_failed_post_build_step() throws Exception {
      */
     @Test
     @Issue("JENKINS-23129")
-    @Ignore("Until JENKINS-23129 is fixed")
     public void trigger_if_succeeds_with_unstable_post_build_step() throws Exception {
         FreeStyleJob j = jenkins.jobs.create();
 

diff --git a/src/test/java/plugins/ScriptlerPluginTest.java b/src/test/java/plugins/ScriptlerPluginTest.java
@@ -40,7 +40,6 @@
 import org.jenkinsci.test.acceptance.po.Slave;
 import org.jenkinsci.test.acceptance.slave.SlaveController;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 
 @WithPlugins("scriptler")

diff --git a/src/test/java/plugins/WorkflowMultibranchTest.java b/src/test/java/plugins/WorkflowMultibranchTest.java
@@ -19,7 +19,6 @@
 import org.jenkinsci.test.acceptance.po.WorkflowMultiBranchJob;
 import org.junit.Assert;
 import org.junit.Before;
-import org.junit.Ignore;
 import org.junit.Test;
 
 /**
@@ -33,7 +32,6 @@ public void setup() {
         MavenInstallation.installMaven(jenkins, "M3", "3.9.4");
     }
 
-    @Ignore("cannot run quickly as anonymous due to github rate limiting")
     @Test
     public void testMultibranchPipeline() {
         final WorkflowMultiBranchJob multibranchJob = jenkins.jobs.create(WorkflowMultiBranchJob.class);