Merge pull request #57 from basil79/prepare-3rd-party

refactoring, rename destroy() to abort(), and added destroy()
basil79 · Aug 23, 2022 · 4a13ea6 · 4a13ea6
2 parents 0b2e239 + 578ccfb
commit 4a13ea6
Show file tree

Hide file tree

Showing 4 changed files with 84 additions and 176 deletions.
diff --git a/README.md b/README.md
@@ -60,7 +60,9 @@ adsManager.addEventListener('AdsManagerLoaded', function() {
 // AdError
 adsManager.addEventListener('AdError', function(adError) {
   if(adsManager) {
-    adsManager.destroy();
+    // abort anything that currenlty doing on with AdsManager
+    // and reset to a default state
+    adsManager.abort();
   }
   // ... 
 });

diff --git a/public/js/ads-manager.js b/public/js/ads-manager.js
diff --git a/public/js/index.js b/public/js/index.js
@@ -1,4 +1,4 @@
-(function() {
+//(function() {
 
     // var playButton = document.getElementById('play-button');
     var testAdButton = document.getElementById('test-ad-button');
@@ -55,7 +55,9 @@
         appendEvent('AdError : ' + adError);
 
         if(adsManager) {
-            adsManager.destroy();
+          // abort anything that currenlty doing on with AdsManager
+          // and reset to a default state
+          adsManager.abort();
         }
 
         isAdPaused = false;
@@ -281,4 +283,4 @@
         clearEvents();
     }, false);
 
-})()
+//})()