Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use cargo workplaces #262

Closed
wants to merge 2 commits into from
Closed

Conversation

paulrouget
Copy link
Contributor

I managed to remove all the warnings.

Please let me know if there's any changes you're not happy with:

  • created 5 crates: core lib, plato, emulator, fetcher and importer.
  • only one structure needed migration (from plato to core): Context
  • i moved mupdf wrapper outside of the rust code, and build it binary within target directory for cleanness reasons
  • removed never used code

I'm still having this warning when cross compiling.

More details here and here.

warning: unknown feature specified for `-Ctarget-feature`: `a9`
  |
  = note: it is still passed through to the codegen backend
  = note: consider filing a feature request

@paulrouget
Copy link
Contributor Author

paulrouget commented Sep 3, 2022

Fix #256

@baskerville
Copy link
Owner

Thanks!

I've only found a small mistake in service.sh for the install_importer case: the correct invocation is cargo install --path crates/importer "$@" and not cargo install --path . -p plato-importer "$@".

Regarding the remaining warning, I think I understand why it shows a warning: in the output of rustc --print target-features --target arm-unknown-linux-gnueabihf, a9 isn't in the rustc table (but is in the LLVM table) while all the other features used in .cargo/config (v7, vfp3, neon) are in the rustc table.

@paulrouget
Copy link
Contributor Author

I've only found a small mistake in service.sh

Fixed

Regarding the remaining warning

I'll file a rustc issue for that. Thank you.

@baskerville
Copy link
Owner

I'm getting a few errors when I try to build the article fetcher with cargo +nightly build --profile release-minsized -Z build-std=std,panic_abort --target arm-unknown-linux-gnueabihf -p fetcher (for example: error: cannot determine resolution for the macro json).

@baskerville
Copy link
Owner

What seems to be causing it is -Z build-std=std,panic_abort.

@paulrouget
Copy link
Contributor Author

I've seen that before. I think it's a crate name mixup. core:: show be renamed. I'll give it a try later.

@paulrouget
Copy link
Contributor Author

@baskerville can you try with the last commit?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants