Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug] Toast error message in productive app when missing picture #86

Closed
GW-FUB opened this issue Dec 8, 2020 · 4 comments
Closed

[Bug] Toast error message in productive app when missing picture #86

GW-FUB opened this issue Dec 8, 2020 · 4 comments

Comments

@GW-FUB
Copy link

GW-FUB commented Dec 8, 2020

Description

When an referenced image is missing a toast message ist saying "Cannot find EmbeddedResource". There should be a possibility to disable this in productive apps.

Steps to Reproduce

  1. Use a forms9Patch.Image in XAML
  2. Set the source to something random (e.g. "notexistingimage.png")
  3. A toast message appears "Cannot find EmbeddedResource"

Expected Behavior

No toast in production

Actual Behavior

A toast message
@baskren
Copy link
Owner

baskren commented Dec 15, 2020

@GW-FUB

I'll be added a new property to the Image class: FailAction (of enum type Forms9Patch.FailAction). This will allow you to either:

  • Ignore
  • ShowAlert
  • ThrowException

There are some other places where it would be nice to have this as well. For now, I'll be adding optional FailAction arguments to the PrintAsync WebView extension methods.

baskren added a commit that referenced this issue Dec 15, 2020
@baskren
Draft fixes for:
a1238cb 
- Issue #86: Toast error message in productive app when missing picture;
- Issue #85: Android crashes when a system font has been added as an asset or resource;
- Issue #83: HtmlText Inline style with space char;
- Issue #82: LineHeight not working (Android);
@baskren
Copy link
Owner

baskren commented Dec 15, 2020

please take a look at version 2.4.9-beta1 and let me know if it fixes this issue. Try out the Image.FailAction property and let me know if this works for you.

@GW-FUB
Copy link
Author

GW-FUB commented Dec 16, 2020

@baskren Yes, works great. Thanks

@GW-FUB GW-FUB closed this as completed Dec 16, 2020
@baskren
Copy link
Owner

baskren commented Dec 16, 2020

Super! Thanks for taking a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@baskren @GW-FUB