Dim to warm

[th3w1zard1]

Set color temp based on sun position AND current brightness. see #78
Calculates color_temp first, then uses that value as a max to then calculate again based on brightness in the following eq:
color_temp_kelvin = ((min_ct-max_ct)/(min_brightness-max_brightness)**2)*(brightness-max_brightness)**2+max_ct
when brightness is the current brightness.

Just set dim_to_warm: true in the config to get started.

Created from version 1.8.0

[basnijholt]

What is the reasoning behind this equation?

Do you perhaps have a graph or something that we can add to the README?

[th3w1zard1]

Yes! please look at the issue #78 I have a graph posted toward the bottom of the thread

[th3w1zard1]

@basnijholt Why are the pre-commit filters so strict on formatting?

Example: custom_components/adaptive_lighting/switch.py:836:101: E501 line too long (106 > 100)

Do I need to fix all of these?

[basnijholt]

The strict formatting is such that one never needs to have discussions about style. The filters dictate the style and that's it 😄

I just fixed the line lengths for you. that was in a different PR

[th3w1zard1]

@basnijholt I don't quite understand these workflow actions. I'm confused by how to effectively use pre-commits but I'll figure it out as I get accustomed.

My main concern is: why is pytest failing on all commits we are pushing? I went back in the timeline and it seems to even be failing on the master branch - spanning back several months?

[basnijholt]

just run pre-commit install once in your repo and you should be set up for life 😄

[th3w1zard1]

just run pre-commit install once in your repo and you should be set up for life 😄

I don't quite understand where I can run that command? I'm using GitHub desktop, but even when I open the terminal and try that command, I get:

C:\Users\*****\Documents\GitHub\adaptive-lighting>pre-commit install
'pre-commit' is not recognized as an internal or external command,
operable program or batch file.

C:\Users\*****\Documents\GitHub\adaptive-lighting>git pre-commit install
git: 'pre-commit' is not a git command. See 'git --help'.

The most similar command is
        verify-commit

C:\Users\*****\Documents\GitHub\adaptive-lighting>

[basnijholt]

You first need to install pre-commit itself with pip install pre-commit.

[basnijholt]

My main concern is: why is pytest failing on all commits we are pushing? I went back in the timeline and it seems to even be failing on the master branch - spanning back several months?

Yes there are 3 tests that are failing, which I want to get to. I am not sure whether the features that it is testing are actually broken or if it is because the test is bad.

[basnijholt]

One thing we could do, is to approximate the equation that Adaptive Lighting is using in Apple HomeKit.

I personally have an unused Philips Hue Hub which I can set up with one of my Hue lights.

Then I would let a light run for 24h at 100% brightness and poll the light each minute for its state with https://github.com/studioimaginaire/phue.
Then I would set the light to 85% brightness and repeat.
Repeat again with decreasing brightness.

We would then have a dataset which with we can determine how to implement this as in HomeKit.

[basnijholt]

I can actually also come up with a scheme to sample all the brightnesses in a single day.

I just need to program the sampling and experiment a bit.

[th3w1zard1]

Brilliant!!

[jacob3089]

This functionality is similar to what I posted in #127 the intent is to allow parts of the day to change both brightness and color temp together instead of changing one or the other if the sun is above or below the horizon.