-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set last_service_data in the right place #652
Conversation
cb6dc3d
to
3d4de6a
Compare
What exactly do you mean re #598? I can't see any To be honest, I never completely understood its purpose, and so I tried to keep this as untouched as I could. But the change you made in here seems reasonable :) |
iirc the last time we touched |
I believe the only thing that changed is that currently the code can set Upon further inspection I think this shouldn't matter and I don't think it breaks anything. I have been reading all changes in detail since there have been some unexplainable errors that people have reported 😅 I also realized that it's always been incorrect for the |
I noticed this changed after #598
@protyposis, was this intentional?