Improve FindServers result handling #25
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If FindServers returns, the list of discovery URLs is put into a combo box and the first entry is selected by default. If the first URL is not reachable, the user has to decide if the URL used for the FindServers call should be attempted. By looking for that URL in the returned discovery URLs list and selecting it if available, this can be omitted in most cases.
basyskom-jvoe
force-pushed
the
feature/improve_discovery_url_selection
branch
from
9748fea to
ceb40cb
Compare
khaexy
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If FindServers returns, the list of discovery URLs is put into a combo box and the first entry is selected by default. If the first URL is not reachable, the user has to decide if the URL used for the FindServers call should be attempted. By looking for that URL in the returned discovery URLs list and selecting it if available, this can be omitted in most cases.