-
Notifications
You must be signed in to change notification settings - Fork 539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kernel patches for asus-armoury and hid-asus-ally #12274
base: master
Are you sure you want to change the base?
add kernel patches for asus-armoury and hid-asus-ally #12274
Conversation
hi @bryanforbes do you actually have this device?
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General comments for feedback.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this disabled?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is included in 6.10.3
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, how is this controlled? or is that for future discussions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That will be future discussions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need this included?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not. I'll remove it and renumber.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how do you control this exactly? we have no means in Batocera
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting /sys/class/firmware-attributes/asus-armoury/attributes/apu_mem/current_value
to a value between 1 and 8. We would have to add this functionality in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, how to control? Intel core
on an AMD device?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setting /sys/class/firmware-attributes/asus-armoury/attributes/cores_performance/current_value
or /sys/class/firmware-attributes/asus-armoury/attributes/cores_efficiency/current_value
. I believe "Intel core enablement" is a feature to tune each core individually. @flukejones can correct me if I'm wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
have you tested. there has been negative feedback about this going about things the wrong way... we can accept it but it looks like it will change. just be mindful of that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not. I'm currently building an image. As soon as I'm done and have tested, I'll update this PR
@dmanlfc I apologize for not adding the information in the original pull request. I own a ROG Ally (not X), so I'll be able to test this. I'm currently building an image (the patches apply cleanly and the kernel compiles). I'll update this PR as I progress. |
67aeaa1
to
6696dfd
Compare
Please be aware that these patches are somewhat in flux at the moment. You may need to replace them in the next week |
No description provided.