Add state for current user #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acrantel
commented
Aug 14, 2023
| @@ -0,0 +1,12 @@ | |||
| import Cookies from "js-cookie"; | |||
There was a problem hiding this comment.
this is a util file that will be used for the login / register pages
|
context omg amaze |
lowtorola
reviewed
Aug 14, 2023
| import React, { useState, useEffect } from "react"; | ||
| import { type UserPrivate } from "../utils/types"; | ||
| import { AuthStateEnum, type AuthState, CurrentUserContext } from "../contexts/CurrentUserContext"; | ||
| import { Api } from "../utils/api"; |
There was a problem hiding this comment.
After #664 is merged, this will need to change to import * as Api 👍
| navigate("/login"); | ||
| return null; | ||
| } else { | ||
| return <p>loading</p>; |
There was a problem hiding this comment.
Should we have a more populated loading screen here (e.g. using Spinner)? Not necessary though, we can just go back and add one later if we need...
There was a problem hiding this comment.
Yup, i'll change this to a centered Spinner in the page
acrantel
added a commit
that referenced
this pull request
Aug 15, 2023
acrantel
added a commit
that referenced
this pull request
Aug 15, 2023
acrantel
added a commit
that referenced
this pull request
Oct 3, 2023
acrantel
added a commit
that referenced
this pull request
Feb 8, 2024
acrantel
added a commit
that referenced
this pull request
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
finally got around to pulling this into a separate pr from the login / register pages...
this pr adds a
CurrentUserContextto hold the state of the current user. It also adds aPrivateRoutecomponent which redirects people to the login page if they are not logged upon load.