Safe Loaders #837
Merged
Safe Loaders #837
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lowtorola
commented
Oct 12, 2024
lowtorola
commented
Oct 12, 2024
lowtorola
commented
Oct 12, 2024
| const loggedIn = await loginCheck(queryClient); | ||
|
|
||
| // Await the episode info so we can be sure that it exists | ||
| const episodeInfo = await queryClient.ensureQueryData({ |
There was a problem hiding this comment.
I'm still awaiting things that I want to e.g. wait or throw to error boundary on 😎
lowtorola
commented
Oct 12, 2024
acrantel
reviewed
Oct 19, 2024
working safe loaders
lowtorola
force-pushed
the
safe-loaders
branch
from
3e30488
to
7e3dad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue of loaders throwing runtime errors. I added a few notes, feel free to give your thoughts on them. tyty