Skip to content
This repository has been archived by the owner on Jun 29, 2024. It is now read-only.

Ios sharing intent #92

Merged
merged 2 commits into from
Jul 10, 2022
Merged

Ios sharing intent #92

merged 2 commits into from
Jul 10, 2022

Conversation

CTimmermann
Copy link

Closes #76

@CTimmermann
Copy link
Author

Quick explanation for the changed line in _DocumentRouteState.uploadSharedDocument():

This is a workaround for some faulty behavior of the receive_sharing_intent plugin.

Without the Uri.decodeFull(), filenames including spaces or German "Umlaute" cause errors (see KasemJaffer/receive_sharing_intent#97).

The replaceAll('file://', '') is necessary due to the behavior discussed here: https://stackoverflow.com/questions/72767865/flutter-receive-sharing-intent-share-pdf-with-ios

@bauerj bauerj changed the base branch from master to ios July 10, 2022 17:38
@bauerj
Copy link
Owner

bauerj commented Jul 10, 2022

Thank you! I'll merge this into the ios branch for now, as I assume it's not ready for production yet.

@bauerj bauerj merged commit f3608e8 into bauerj:ios Jul 10, 2022
@bauerj
Copy link
Owner

bauerj commented Jul 10, 2022

I'll also have to test whether the file sharing still works in Android with your replaceAll('file://', '') change. Otherwise we'll have to make that one conditional on OS.

@CTimmermann CTimmermann mentioned this pull request Jan 2, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Share PDFs with Paperless App for uploading
3 participants