feat: add a module extension for http_archive #341
Conversation
kormide
force-pushed
the
bzlmod-http-archive
branch
from
602fa29
to
8068985
Compare
|
|
||
| # Extension that can declare http repository rules, until there's a better way: | ||
| # https://github.com/bazelbuild/bazel/issues/17141 | ||
| http = module_extension( |
There was a problem hiding this comment.
It seems a little gross, but comments on that issue from Keith make me think that someone has to have that code somewhere, so bazel-lib is the best place we have.
@fmeum do you have any opinion about it?
There was a problem hiding this comment.
Yes, please don't do it :-) It suggests that something works that is inherently broken: The names provided to the extension tag need to be globally unique, which they will be in small projects and then break when composed with other modules.
It's fine if someone builds this for their own module (and thus have the generated repos scoped under this one-off extension), but having it available in a general purpose skylib-like library makes it more likely these collisions will happen in practice and break the "strict deps" promise of Bzlmod.
I think that we should just accept the overhead of wrapping a bunch of http_archives in a macro and making it a module extension for now and wait for a resolution to bazelbuild/bazel#17141.
There is a rules_js e2e I want to convert to bzlmod that uses
http_archivein the WORKSPACE file. I could just use a workspace file alongside a MODULE.bazel file, but I thought of doing this. Wdyt?Related to bazelbuild/bazel#17141.