feat(bzlmod): mark toolchains extension as reproducible #970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@cerisier it seems you didn't allow maintainers to push to your PR branch, so I can't rebase this for you to pick up the updated GHA workflow that satisfies our required check. Could you rebase to current HEAD pls? |
auto-merge was automatically disabled
December 7, 2024 16:21
Head branch was pushed to by a user without write access
cerisier
force-pushed
the
reproducible-extension
branch
from
8557ef4 to
a16fe8f
Compare
|
@alexeagle done ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Marking the toolchains extension as reproducible since all underlying tools are already checked for integrity. Saving an entry in the lockfile for that extension.
Marking this has to be conditional to
bazel_features.external_deps.extension_metadata_has_reproducible, hence bumpingbazel_featuresto 1.9.0 which is the version introducing the check (https://github.com/bazel-contrib/bazel_features/releases/tag/v1.9.0)