Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bats_test): use env var rather than symbolic link #991

Merged
merged 1 commit into from
Dec 6, 2024
Merged

Conversation

alexeagle
Copy link
Collaborator

@alexeagle alexeagle commented Dec 6, 2024

This allows it to work on Windows as well.

Fixes red main build following #982
(note that the CI setup for this repo saves GHA quota by not running tests on Windows for all PRs, only when they come from a branch with 'windows' in the name)

Tested by using a little-known feature where Bazel can report the test case names:

$ bazel test lib/tests/bats:basic --test_summary=detailed
INFO: Analyzed target //lib/tests/bats:basic (3 packages loaded, 947 targets configured).
INFO: Found 1 test target...
Target //lib/tests/bats:basic up-to-date:
  bazel-bin/lib/tests/bats/basic_bats.sh
INFO: Elapsed time: 0.399s, Critical Path: 0.21s
INFO: 3 processes: 2 internal, 1 linux-sandbox.
INFO: Build completed successfully, 3 total actions
//lib/tests/bats:basic                                                   PASSED in 0.2s
    PASSED  basic.bats.assert_output() check for existence (0.0s)
Test cases: finished with 1 passing and 0 failing out of 1 test cases

@alexeagle alexeagle requested a review from thesayyn December 6, 2024 16:39
This allows it to work on Windows as well.
@alexeagle alexeagle enabled auto-merge (squash) December 6, 2024 16:41
@alexeagle alexeagle merged commit e17dee2 into main Dec 6, 2024
35 checks passed
@alexeagle alexeagle deleted the windows-fix branch December 6, 2024 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants