Build against glibc 2.26 #41
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
illicitonion
force-pushed
the
amazonlinux
branch
4 times, most recently
from
82e240a
to
51c0bf0
Compare
Previously we were building against glibc 2.26. amazonlinux 2 has 2.26, and we have users wanting to use this, so let's jump back a couple of glibcs to support them. Another advantage here is that amazonlinux maintains `yum` working out of the box, rather than needing to configure mirrors. A down-side is that the `node` version used by the `checkout` action links a newer glibc than 2.26. For now we activate a hatch to revert to an older node, but in the future we may need to work around another way, e.g. by manually checking out the source ourselves instead of relying on the actions action which relies on node. We also now perform container set-up before the checkout action, so we can set up the tools it assumes (e.g. `tar`)
illicitonion
force-pushed
the
amazonlinux
branch
from
51c0bf0
to
a7a0508
Compare
fmeum
approved these changes
Sep 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were building against glibc 2.26.
amazonlinux 2 has 2.26, and we have users wanting to use this, so let's
jump back a couple of glibcs to support them.
Another advantage here is that amazonlinux maintains
yumworking outof the box, rather than needing to configure mirrors.
A down-side is that the
nodeversion used by thecheckoutactionlinks a newer glibc than 2.26. For now we activate a hatch to revert to
an older node, but in the future we may need to work around another way,
e.g. by manually checking out the source ourselves instead of relying on
the actions action which relies on node.