feat: include release url in pr body

bazel-contrib · Nov 6, 2023 · 3dffc30 · 3dffc30
1 parent c7b46e8
commit 3dffc30
Show file tree

Hide file tree

Showing 3 changed files with 50 additions and 7 deletions.
diff --git a/src/application/release-event-handler.ts b/src/application/release-event-handler.ts
@@ -42,6 +42,7 @@ export class ReleaseEventHandler {
         event.payload.sender.login,
         repository
       );
+      const releaseUrl = event.payload.release.url;
 
       const tag = event.payload.release.tag_name;
 
@@ -110,7 +111,8 @@ export class ReleaseEventHandler {
                 bcr,
                 branch,
                 releaser,
-                rulesetRepo.getModuleName(moduleRoot)
+                rulesetRepo.getModuleName(moduleRoot),
+                releaseUrl
               );
 
               console.log(`Created pull request against ${bcr.canonicalName}`);

diff --git a/src/domain/publish-entry.spec.ts b/src/domain/publish-entry.spec.ts
@@ -31,7 +31,8 @@ describe("sendRequest", () => {
       bcr,
       branch,
       releaser,
-      "rules_foo"
+      "rules_foo",
+      `github.com/aspect-build/rules_foo/releases/tag/${tag}`
     );
 
     expect(mockGithubClient.createPullRequest).toHaveBeenCalledWith(
@@ -61,7 +62,8 @@ describe("sendRequest", () => {
       bcr,
       branch,
       releaser,
-      "rules_foo"
+      "rules_foo",
+      `github.com/aspect-build/rules_foo/releases/tag/${tag}`
     );
 
     expect(mockGithubClient.createPullRequest).toHaveBeenCalledWith(
@@ -99,7 +101,8 @@ describe("sendRequest", () => {
       bcr,
       branch,
       releaser,
-      "rules_foo"
+      "rules_foo",
+      `github.com/aspect-build/rules_foo/releases/tag/${tag}`
     );
 
     expect(mockGithubClient.createPullRequest).toHaveBeenCalledWith(
@@ -112,6 +115,39 @@ describe("sendRequest", () => {
     );
   });
 
+  test("incliudes the release url in the body", async () => {
+    const bcrFork = new Repository("bazel-central-registry", "bar");
+    const bcr = new Repository("bazel-central-registry", "bazelbuild");
+    const branch = "branch_with_entry";
+    const tag = "v1.0.0";
+    const releaser = {
+      name: "Json Bearded",
+      username: "json",
+      email: "jason@foo.org",
+    };
+
+    await publishEntryService.sendRequest(
+      tag,
+      bcrFork,
+      bcr,
+      branch,
+      releaser,
+      "rules_foo",
+      `github.com/aspect-build/rules_foo/releases/tag/${tag}`
+    );
+
+    expect(mockGithubClient.createPullRequest).toHaveBeenCalledWith(
+      expect.any(Repository),
+      expect.any(String),
+      expect.any(Repository),
+      expect.any(String),
+      expect.any(String),
+      expect.stringContaining(
+        `github.com/aspect-build/rules_foo/releases/tag/${tag}`
+      )
+    );
+  });
+
   test("creates the created pull request number", async () => {
     const bcrFork = new Repository("bazel-central-registry", "bar");
     const bcr = new Repository("bazel-central-registry", "bazelbuild");
@@ -131,7 +167,8 @@ describe("sendRequest", () => {
       bcr,
       branch,
       releaser,
-      "rules_foo"
+      "rules_foo",
+      `github.com/aspect-build/rules_foo/releases/tag/${tag}`
     );
 
     expect(pr).toEqual(4);

diff --git a/src/domain/publish-entry.ts b/src/domain/publish-entry.ts
@@ -12,17 +12,21 @@ export class PublishEntryService {
     bcr: Repository,
     branch: string,
     releaser: User,
-    moduleName: string
+    moduleName: string,
+    releaseUrl: string
   ): Promise<number> {
     const version = RulesetRepository.getVersionFromTag(tag);
+
     const pr = await this.githubClient.createPullRequest(
       bcrForkRepo,
       branch,
       bcr,
       "main",
       `${moduleName}@${version}`,
       `\
-Release author: @${releaser.username}.
+Release: [${tag}](${releaseUrl})
+
+Author: @${releaser.username}.
 
 Automated by [Publish to BCR](https://github.com/apps/publish-to-bcr).`
     );