fix: recognize explicitly empty version strings #175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmeum
added a commit
to bazel-contrib/bazel-gazelle
that referenced
this pull request
Nov 12, 2024
The new style also isn't supported by Publish to BCR and a fix is in flight: bazel-contrib/publish-to-bcr#175
fmeum
added a commit
to bazel-contrib/bazel-gazelle
that referenced
this pull request
Nov 12, 2024
**What type of PR is this?** Bug fix **What package or component does this PR mostly affect?** BCR **What does this PR do? Why is it needed?** The new style also isn't supported by Publish to BCR and a fix is in flight: bazel-contrib/publish-to-bcr#175 **Which issues(s) does this PR fix?** Fixes # **Other notes for review**
|
Thanks! Added a commit to update the e2es. |
kormide
approved these changes
Nov 12, 2024
|
Please squash when merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
moduledirective withversion = ""resulted in the version being stamped into the firstbazel_dep.Also fix the indentation to follow
buildifier's style.