Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: expose version values via bazel_binaries.versions #132

Merged
merged 4 commits into from
Mar 16, 2023

Conversation

cgrindel
Copy link
Member

Clients that are using bzlmod now only need to specify the Bazel versions in their MODULE.bazel. The bazel_versions.bzl is no longer necessary.

  • Update bazel_binaries to provide the version information.
  • Update workspace_bazel_binaries to consume the version info so that it can also provide it.

Closes #125.

@cgrindel cgrindel self-assigned this Mar 16, 2023
@cgrindel cgrindel force-pushed the gh125_genrate_bazel_versions branch from 1eeed31 to c229a18 Compare March 16, 2023 20:19
@cgrindel cgrindel requested a review from kormide March 16, 2023 20:20
@cgrindel cgrindel mentioned this pull request Mar 16, 2023
14 tasks
@cgrindel cgrindel merged commit 0ae1e07 into main Mar 16, 2023
@cgrindel cgrindel deleted the gh125_genrate_bazel_versions branch March 16, 2023 21:11
renovate bot referenced this pull request in cgrindel/rules_swift_package_manager Mar 26, 2023
#306)

[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[rules_bazel_integration_test](https://github.com/bazel-contrib/rules_bazel_integration_test)
| http_archive | minor | `v0.11.1` -> `v0.12.0` |

---

### Release Notes

<details>
<summary>bazel-contrib/rules_bazel_integration_test</summary>

###
[`v0.12.0`](https://github.com/bazel-contrib/rules_bazel_integration_test/releases/tag/v0.12.0)

[Compare
Source](https://github.com/bazel-contrib/rules_bazel_integration_test/compare/v0.11.1...v0.12.0)

#### What's Changed

- Update README.md for v0.11.1 by
[@&#8203;auth-for-create-pull-request](https://github.com/auth-for-create-pull-request)
in
[https://github.com/bazel-contrib/rules_bazel_integration_test/pull/131](https://github.com/bazel-contrib/rules_bazel_integration_test/pull/131)
- feat: expose version values via `bazel_binaries.versions` by
[@&#8203;cgrindel](https://github.com/cgrindel) in
[https://github.com/bazel-contrib/rules_bazel_integration_test/pull/132](https://github.com/bazel-contrib/rules_bazel_integration_test/pull/132)
- chore(deps): update dependency rules_python to v0.20.0 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/bazel-contrib/rules_bazel_integration_test/pull/134](https://github.com/bazel-contrib/rules_bazel_integration_test/pull/134)
- chore(deps): update dependency cgrindel_bazel_starlib to v0.15.0 by
[@&#8203;renovate](https://github.com/renovate) in
[https://github.com/bazel-contrib/rules_bazel_integration_test/pull/140](https://github.com/bazel-contrib/rules_bazel_integration_test/pull/140)
- chore: move `workspace_bazel_binaries` functionality to
`bazel_binaries.bzl`. by
[@&#8203;cgrindel](https://github.com/cgrindel) in
[https://github.com/bazel-contrib/rules_bazel_integration_test/pull/141](https://github.com/bazel-contrib/rules_bazel_integration_test/pull/141)

**Full Changelog**:
bazel-contrib/rules_bazel_integration_test@v0.11.1...v0.12.0

#### Workspace Snippet

```python
http_archive(
    name = "rules_bazel_integration_test",
    sha256 = "0a1edb5ceb2797e463d40c0ae1c1b0de2c12104304ce07930a43ba4c9a314f85",
    urls = [
        "https://github.com/bazel-contrib/rules_bazel_integration_test/releases/download/v0.12.0/rules_bazel_integration_test.v0.12.0.tar.gz",
    ],
)

load("@&#8203;rules_bazel_integration_test//bazel_integration_test:deps.bzl", "bazel_integration_test_rules_dependencies")

bazel_integration_test_rules_dependencies()

load("@&#8203;cgrindel_bazel_starlib//:deps.bzl", "bazel_starlib_dependencies")

bazel_starlib_dependencies()

load("@&#8203;bazel_skylib//:workspace.bzl", "bazel_skylib_workspace")

bazel_skylib_workspace()
```

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR is behind base branch, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://app.renovatebot.com/dashboard#github/cgrindel/swift_bazel).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xNC4yIiwidXBkYXRlZEluVmVyIjoiMzUuMTQuMiJ9-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
cgrindel added a commit to k1nkreet/rules_bazel_integration_test that referenced this pull request Sep 27, 2023
…rib#132)

Clients that are using bzlmod now only need to specify the Bazel
versions in their `MODULE.bazel`. The `bazel_versions.bzl` is no longer
necessary.
- Update `bazel_binaries` to provide the version information.
- Update `workspace_bazel_binaries` to consume the version info so that
it can also provide it.

Closes bazel-contrib#125.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update bzlmod support to use bazel_versions.bzl and reduce boilerplate
2 participants