Feat cuda version #144
Closed
Feat cuda version #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haibozhang123
requested review from
cloudhan,
jsharpe and
ryanleary
as code owners
jsharpe
reviewed
Aug 22, 2023
WORKSPACE.bazel
Outdated
| @@ -7,7 +7,7 @@ local_repository( | |||
|
|
|||
| load("//cuda:repositories.bzl", "register_detected_cuda_toolchains", "rules_cuda_dependencies") | |||
|
|
|||
| rules_cuda_dependencies() | |||
| rules_cuda_dependencies("11.8") | |||
There was a problem hiding this comment.
These can't be hardcoded as this breaks the CI tests of different versions of CUDA
examples/WORKSPACE.bazel
Outdated
| @@ -14,6 +14,5 @@ local_repository( | |||
|
|
|||
| load("@rules_cuda//cuda:repositories.bzl", "register_detected_cuda_toolchains", "rules_cuda_dependencies") | |||
|
|
|||
| rules_cuda_dependencies() | |||
|
|
|||
| rules_cuda_dependencies("11.8") | |||
cuda/runtime/BUILD.local_cuda
Outdated
| target_compatible_with = ["@platforms//os:windows"], | ||
| ) | ||
|
|
||
| cc_import( | ||
| name = "cudadevrt_lib", | ||
| interface_library = "cuda/lib/x64/cudadevrt.lib", | ||
| system_provided = 1, | ||
| #shared_library = "cuda/bin/cudart64_"+ str(cuda_package_version("cuda_cudart")) + ".dll", |
cuda/runtime/BUILD.local_cuda
Outdated
| @@ -52,14 +55,15 @@ cc_library( | |||
| cc_import( | |||
| name = "cudart_lib", | |||
| interface_library = "cuda/lib/x64/cudart.lib", | |||
| system_provided = 1, | |||
| shared_library = "cuda/bin/cudart64_"+ str(cuda_package_version("cuda_cudart")) + ".dll", | |||
There was a problem hiding this comment.
This seems like it might be x64 specific from the name? Do you need to also provide the 32 bit variants of these libraries or are they always only 64 bit? I'm not so familiar with cuda libraries on windows.
If its x64 only then the target_compatible_with option will also need updating.
cuda/private/repositories.bzl
Outdated
| @@ -232,4 +311,5 @@ def rules_cuda_dependencies(toolkit_path = None): | |||
| ], | |||
| ) | |||
|
|
|||
| local_cuda(name = "local_cuda", toolkit_path = toolkit_path) | |||
| local_cuda(name = "local_cuda", cuda_version = cuda_version, toolkit_path = toolkit_path) | |||
There was a problem hiding this comment.
There's similar calls to local_cuda that need updating in the bzlmod module extension in cuda/extensions.bzl. You'll need to expose this same cuda_version option in the modules tag_class.
|
Why is this needed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
support specaified CUDA Version
Issue:
In some cases, system have different version's CUDA toolkit ，so it need to specified CUDA version param（like Windows CI client-server ，and need to build history code to get stable unified products ）
so it to need to specified CUDA version
If special CUDA version , bazel test need to get special CUDA version's shared library runtime file ( dll file)
effect :
if not set cuda_version or dll_runtime_system_provided param (default none or True), it will be no impact
if set CUDA version and can not find cuda_version 's CUDA toolkit, it will find CUDA in system as old logic, it will be no impact