Make it clear that "integrity" field expects SRI #259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't think this is a related thing at all. The page referenced is a doc for web developers. The SRI suggested is for validating resources embedded in the html, it just happens to have common meaning with the checksum. This change actually look really bad to me. |
archive_override() uses SRI for checksum: https://bazel.build/rules/lib/globals/module#archive_override. It's somewhat obscure (e.g. checksum are encoded in base64 instead of hexstring). I added #268 hoping to make it clearer and less verbose. |
|
@zifeitong Thanks for pointing out. I am OK with either format. Simply put |
anakinxc
referenced
this pull request
in secretflow/spu
Aug 24, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [rules_cuda](https://github.com/bazel-contrib/rules_cuda) | http_archive | patch | `v0.2.2` -> `v0.2.3` | --- ### Release Notes <details> <summary>bazel-contrib/rules_cuda (rules_cuda)</summary> ### [`v0.2.3`](https://github.com/bazel-contrib/rules_cuda/releases/tag/v0.2.3) [Compare Source](https://github.com/bazel-contrib/rules_cuda/compare/v0.2.2...v0.2.3) #### `WORKSPACE` code ```starlark load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "rules_cuda", sha256 = "c92b334d769a07cd991b7675b2f6076b8b95cd3b28b14268a2f379f8baae58e0", strip_prefix = "rules_cuda-v0.2.3", urls = ["https://github.com/bazel-contrib/rules_cuda/releases/download/v0.2.3/rules_cuda-v0.2.3.tar.gz"], ) load("@​rules_cuda//cuda:repositories.bzl", "register_detected_cuda_toolchains", "rules_cuda_dependencies") rules_cuda_dependencies() register_detected_cuda_toolchains() ``` #### What's Changed - Make it clear that "integrity" field expects SRI by [@​zifeitong](https://github.com/zifeitong) in [https://github.com/bazel-contrib/rules_cuda/pull/259](https://github.com/bazel-contrib/rules_cuda/pull/259) - Fix strip_prefix when publishing to BCR by [@​jsharpe](https://github.com/jsharpe) in [https://github.com/bazel-contrib/rules_cuda/pull/269](https://github.com/bazel-contrib/rules_cuda/pull/269) #### New Contributors - [@​zifeitong](https://github.com/zifeitong) made their first contribution in [https://github.com/bazel-contrib/rules_cuda/pull/259](https://github.com/bazel-contrib/rules_cuda/pull/259) **Full Changelog**: bazel-contrib/rules_cuda@v0.2.2...v0.2.3 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View the [repository job log](https://developer.mend.io/github/secretflow/spu). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOC4yNi4xIiwidXBkYXRlZEluVmVyIjoiMzguMjYuMSIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiZGVwZW5kZW5jaWVzIl19--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
](https://renovatebot.com){kind=link}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Documented in https://developer.mozilla.org/en-US/docs/Web/Security/Subresource_Integrity