Skip to content

Commit

Permalink
Fix overriden framework dependencies (#386)
Browse files Browse the repository at this point in the history
* Fix overriden framework dependencies

## What?
* Fixes overriding of dependencies that are part of the target framework
* Replaces `private_deps` with `targeting_packs` to make it more clear where to put the targeting packs
  • Loading branch information
purkhusid authored Sep 23, 2023
1 parent ab7e043 commit 03ac96a
Show file tree
Hide file tree
Showing 85 changed files with 758 additions and 469 deletions.
33 changes: 33 additions & 0 deletions .bazelci/presubmit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,22 @@ tasks:
- "--config=remote"
test_flags:
- "--config=remote"
rbe_ubuntu1604_no_strict_deps:
name: Rules on Linux (RBE) without strict deps
platform: rbe_ubuntu1604
include_json_profile:
- build
- test
build_targets:
- "//..."
test_targets:
- "//..."
build_flags:
- "--@rules_dotnet//dotnet/settings:strict_deps=false"
- "--config=remote"
test_flags:
- "--@rules_dotnet//dotnet/settings:strict_deps=false"
- "--config=remote"
macos:
name: Rules on MacOS
platform: macos
Expand Down Expand Up @@ -97,3 +113,20 @@ tasks:
- "--config=remote"
test_flags:
- "--config=remote"
examples-rbe_ubuntu1604_no_strict_deps:
name: Examples on Ubuntu 18.04 (RBE) without strict deps
platform: rbe_ubuntu1604
include_json_profile:
- build
- test
working_directory: examples
build_targets:
- "//..."
test_targets:
- "//..."
build_flags:
- "--config=remote"
- "--@rules_dotnet//dotnet/settings:strict_deps=false"
test_flags:
- "--config=remote"
- "--@rules_dotnet//dotnet/settings:strict_deps=false"
6 changes: 3 additions & 3 deletions docs/csharp_binary.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions docs/csharp_library.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions docs/csharp_test.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading

0 comments on commit 03ac96a

Please sign in to comment.