Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implements pcl cmake_external build rule #68

Merged
merged 6 commits into from
Sep 5, 2018

Conversation

bbarnes52-zz
Copy link

No description provided.

@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@irengrig
Copy link
Contributor

Thank you for the patch! Could you please check that about the CLA? (See automatic comment)

@irengrig
Copy link
Contributor

Also, seems it uses locally installed Boost. Which would be anyway not so trivial to compile in an example :)
We should probably add a comment about that..

@bbarnes52-zz
Copy link
Author

testing CLI check

@irengrig
Copy link
Contributor

It seems that you attached the testing commit which you did not intent to include in pull request :)

Also, please sign the CLA, I can not merge the pull request without that.

@bbarnes52-zz bbarnes52-zz force-pushed the master branch 2 times, most recently from b38adfd to f731dcd Compare September 5, 2018 00:17
@googlebot
Copy link

CLAs look good, thanks!

@bbarnes52-zz
Copy link
Author

Whoops, reset that last commit. Updated the author to match the email with which I signed the CLI, and added a comment about dependency on locally installed Boost.

Any advice on how to get rid of that local dependency?

- build boost library and use it as dependency
- add/correct some properties
@irengrig
Copy link
Contributor

irengrig commented Sep 5, 2018

I created a pull request to your fork with building boost.

Also, seems that we are using different versions of CMake, can not think of other differences - but for me it works only if I specify EIGEN_INCLUDE_DIR and FLANN_INCLUDE_DIR, not DIRS variant.
Lets keep both variants, it does not affect anything.

I was able to build the target in 4500 seconds :)

bbarnes52 and others added 4 commits September 5, 2018 12:47
@irengrig irengrig merged commit 9949b17 into bazel-contrib:master Sep 5, 2018
@irengrig
Copy link
Contributor

irengrig commented Sep 5, 2018

Cool, we did it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants