-
Notifications
You must be signed in to change notification settings - Fork 249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implements pcl cmake_external build rule #68
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
Thank you for the patch! Could you please check that about the CLA? (See automatic comment) |
Also, seems it uses locally installed Boost. Which would be anyway not so trivial to compile in an example :) |
testing CLI check |
It seems that you attached the testing commit which you did not intent to include in pull request :) Also, please sign the CLA, I can not merge the pull request without that. |
b38adfd
to
f731dcd
Compare
CLAs look good, thanks! |
Whoops, reset that last commit. Updated the author to match the email with which I signed the CLI, and added a comment about dependency on locally installed Boost. Any advice on how to get rid of that local dependency? |
- build boost library and use it as dependency - add/correct some properties
I created a pull request to your fork with building boost. Also, seems that we are using different versions of CMake, can not think of other differences - but for me it works only if I specify EIGEN_INCLUDE_DIR and FLANN_INCLUDE_DIR, not DIRS variant. I was able to build the target in 4500 seconds :) |
Improve example with building PCL (Point Cloud Library):
- build boost library and use it as dependency - add/correct some properties
Cool, we did it! |
No description provided.