Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macro that faciliates "bazel run" of binary generated by rules_foreign_cc #971

Merged
merged 6 commits into from
Nov 3, 2022
Merged

Add macro that faciliates "bazel run" of binary generated by rules_foreign_cc #971

merged 6 commits into from
Nov 3, 2022

Commits on Nov 3, 2022

  1. Fix build on Windows if PATH is specified 

    Previously, ff a target were to set the PATH variable in the `env`
attribute, the prepending of the path to the MSVC linker to the PATH
variable did not take effect, causing link failures as MSYS's "link.exe"
executable would instead be used.
    @jheaff1
    jheaff1 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    374ff68 View commit details
    Browse the repository at this point in the history

  2. Remove unnecessary :$$PATH suffix 

    The existing PATH is appended to user-defined PATH additions in
framework.bzl
    @jheaff1
    jheaff1 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    833f630 View commit details
    Browse the repository at this point in the history

  3. Add macro that faciliates "bazel run" of binary generated by 

    rules_foreign_cc
    @jheaff1
    jheaff1 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    4747c1d View commit details
    Browse the repository at this point in the history

  4. Remove sandboxed macos tests from ci that depend on shared libs, which 

    is currently broken in bazel
    @jheaff1
    jheaff1 committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    34f86d0 View commit details
    Browse the repository at this point in the history

  5. Update foreign_cc/private/runnable_binary_wrapper.sh

    @jsharpe
    jsharpe committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    83248bc View commit details
    Browse the repository at this point in the history

  6. Merge branch 'main' into runnable_bin

    @jsharpe
    jsharpe committed Nov 3, 2022
    Configuration menu
    Copy the full SHA
    43b8ff1 View commit details
    Browse the repository at this point in the history