Fixing default includes of nogo (#4195)

Currently, nogo will only run within rules_go, not the main repo, by default. This PR also remove the setting of `includes` in tests by default to expose issues in the default `includes` of `go_register_nogo` Fixes #4194 --------- Co-authored-by: Fabian Meumertzheim <fabian@meumertzhe.im>
bazel-contrib · Dec 13, 2024 · 54293b3 · 54293b3
1 parent 6e4fdcf
commit 54293b3
Show file tree

Hide file tree

Showing 3 changed files with 2 additions and 3 deletions.
diff --git a/examples/basic-gazelle/.bazelversion b/examples/basic-gazelle/.bazelversion
@@ -0,0 +1 @@
+7.4.1
diff --git a/go/private/nogo.bzl b/go/private/nogo.bzl
@@ -13,7 +13,7 @@
 # limitations under the License.
 
 DEFAULT_NOGO = "@io_bazel_rules_go//:default_nogo"
-NOGO_DEFAULT_INCLUDES = [str(Label("//:__subpackages__"))]
+NOGO_DEFAULT_INCLUDES = ["@@//:__subpackages__"]
 NOGO_DEFAULT_EXCLUDES = []
 
 # repr(Label(...)) does not emit a canonical label literal.

diff --git a/go/tools/bazel_testing/bazel_testing.go b/go/tools/bazel_testing/bazel_testing.go
@@ -583,8 +583,6 @@ go_register_nogo(
 		"{{ . }}",
 	{{ end }}
 	],
-	{{ else }}
-	includes = ["all"],
 	{{ end}}
 	{{ if .NogoExcludes }}
 	excludes = [