Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to Starlark C/C++ toolchain API #1744

Closed
jayconrod opened this issue Oct 2, 2018 · 1 comment · Fixed by #1768
Closed

Migrate to Starlark C/C++ toolchain API #1744

jayconrod opened this issue Oct 2, 2018 · 1 comment · Fixed by #1768
Labels
cgo enhancement

Comments

@jayconrod
Copy link
Contributor

No description provided.

jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Oct 2, 2018
Use find_cpp_toolchain instead of ctx.fragments.cpp
c1f4e2d 
ctx.fragments.cpp is deprecated.

This doesn't fully get us away from deprecated APIs. We should use
cc_common for flags and C/C++ compilation command lines.

Related bazel-contrib#1744
@jayconrod jayconrod mentioned this issue Oct 2, 2018
Merged
jayconrod added a commit that referenced this issue Oct 2, 2018
@jayconrod
Use find_cpp_toolchain instead of ctx.fragments.cpp (#1747)
afdd1a9 
ctx.fragments.cpp is deprecated.

This doesn't fully get us away from deprecated APIs. We should use
cc_common for flags and C/C++ compilation command lines.

Related #1744
jayconrod added a commit that referenced this issue Oct 3, 2018
@jayconrod
Use find_cpp_toolchain instead of ctx.fragments.cpp (#1747)
e8bbd11 
ctx.fragments.cpp is deprecated.

This doesn't fully get us away from deprecated APIs. We should use
cc_common for flags and C/C++ compilation command lines.

Related #1744
jayconrod added a commit that referenced this issue Oct 3, 2018
@jayconrod
Use find_cpp_toolchain instead of ctx.fragments.cpp (#1747)
6fbc358 
ctx.fragments.cpp is deprecated.

This doesn't fully get us away from deprecated APIs. We should use
cc_common for flags and C/C++ compilation command lines.

Related #1744
jayconrod added a commit that referenced this issue Oct 3, 2018
@jayconrod
Use find_cpp_toolchain instead of ctx.fragments.cpp (#1747)
8372098 
ctx.fragments.cpp is deprecated.

This doesn't fully get us away from deprecated APIs. We should use
cc_common for flags and C/C++ compilation command lines.

Related #1744
@jayconrod jayconrod mentioned this issue Oct 5, 2018
Open
@jayconrod
Copy link
Contributor Author

Make sure to fix #1486 as part of this.

jayconrod pushed a commit to jayconrod/rules_go that referenced this issue Oct 15, 2018
Migrate to cc_common for collecting C/C++ paths and options
bb01735 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes bazel-contrib#1744
Related bazel-contrib#1742
@jayconrod jayconrod mentioned this issue Oct 15, 2018
Merged
jayconrod added a commit that referenced this issue Oct 16, 2018
@jayconrod
Migrate to cc_common for collecting C/C++ paths and options (#1768)
6fa12b1 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes #1744
Related #1742
jayconrod added a commit that referenced this issue Oct 16, 2018
@jayconrod
Migrate to cc_common for collecting C/C++ paths and options (#1768)
c414e7c 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes #1744
Related #1742
jayconrod added a commit that referenced this issue Oct 16, 2018
@jayconrod
Migrate to cc_common for collecting C/C++ paths and options (#1768)
3c97a6a 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes #1744
Related #1742
jayconrod added a commit that referenced this issue Oct 16, 2018
@jayconrod
Migrate to cc_common for collecting C/C++ paths and options (#1768)
92bafce 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes #1744
Related #1742
jayconrod added a commit that referenced this issue Oct 16, 2018
@jayconrod
Migrate to cc_common for collecting C/C++ paths and options (#1768)
defc130 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes #1744
Related #1742
jayconrod added a commit that referenced this issue Oct 16, 2018
@jayconrod
Migrate to cc_common for collecting C/C++ paths and options (#1768)
89603ad 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes #1744
Related #1742
jayconrod added a commit that referenced this issue Oct 16, 2018
@jayconrod
Migrate to cc_common for collecting C/C++ paths and options (#1768)
af8850e 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes #1744
Related #1742
jayconrod added a commit that referenced this issue Oct 16, 2018
@jayconrod
Migrate to cc_common for collecting C/C++ paths and options (#1768)
dde4865 
Previously, the internal go_context_data read C/C++ paths and options
from the CcToolchainInfo provider. Most of the fields in this provider
come from CROSSTOOL and will be removed in Bazel 0.20.0 (see
https://docs.bazel.build/versions/master/skylark/backward-compatibility.html#disable-legacy-c-toolchain-api).

This change migrates us to use the new cc_common module. This change
is intended to be a quick fix to be backported to old release
branches, so no architectural changes are made.

Fixes #1744
Related #1742
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cgo enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate to cc_common for collecting C/C++ paths and options jayconrod/rules_go
1 participant
@jayconrod