Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle relative import paths. #102

Merged
merged 2 commits into from
Sep 16, 2016

Conversation

melindalu
Copy link
Contributor

We ran into a problem with imports using relative paths to reference packages in the same repository of the form "../othersubpackage". @yugui @pmbethe09 does this look reasonable?

@bazel-io
Copy link

Can one of the admins verify this patch?

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@melindalu
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@yugui
Copy link
Contributor

yugui commented Sep 16, 2016

@melindalu
LGTM, but could you name the importpath lib/relativeimporter or just lib/relative instead oflib/relative_importer to avoid underscore character?

Jenkins, test this please.

@melindalu
Copy link
Contributor Author

@yugui good point, thanks — changed.

@pmbethe09
Copy link
Contributor

LGTM

@pmbethe09 pmbethe09 merged commit 363e97c into bazel-contrib:master Sep 16, 2016
@melindalu melindalu deleted the fix-relative-paths branch September 17, 2016 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants