Add compatibility repository for supporting older Bazel versions #1933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
io_bazel_rules_go_compat is a new repository, which contains compat.bzl, a symbolic link to a file in go/private/compat. There are multiple versions that compat.bzl may point to (v18.bzl, v22.bzl initially). These files provide the same definitions with different implementations. Initially, this provides abstraction for accessing cc and proto providers, which are changing in Bazel 0.23. Fixes bazel-contrib#1888
jayconrod
added a commit
that referenced
this pull request
Feb 25, 2019
io_bazel_rules_go_compat is a new repository, which contains compat.bzl, a symbolic link to a file in go/private/compat. There are multiple versions that compat.bzl may point to (v18.bzl, v22.bzl initially). These files provide the same definitions with different implementations. Initially, this provides abstraction for accessing cc and proto providers, which are changing in Bazel 0.23. Fixes #1888
This was referenced Feb 28, 2019
cloud-robotics-github-robot
pushed a commit
to googlecloudrobotics/core
that referenced
this pull request
Mar 5, 2019
Due to a change in how the dependencies work, we need to be careful to load go_repository from deps.bzl, not def.bzl: bazel-contrib/rules_go#1933 Additionally, Gazelle 0.17.0 seems to find the dependencies in src/.gopath, so I've added a gazelle:ignore directive for them. At the same time, I've added the path to .bazelignore, so that Bazel doesn't try to build or run files in there. This pulls in some Bazel compatibility fixes (#2). Change-Id: Ic215ca30c0e6bb438e8fff134e439e4e4a032879 GitOrigin-RevId: 8c7708b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
io_bazel_rules_go_compat is a new repository, which contains
compat.bzl, a symbolic link to a file in go/private/compat. There are
multiple versions that compat.bzl may point to (v18.bzl, v22.bzl
initially). These files provide the same definitions with different
implementations.
Initially, this provides abstraction for accessing cc and proto
providers, which are changing in Bazel 0.23.
Fixes #1888