files_equal_test: rewrite as genrule + sh_test #2035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper
jayconrod
pushed a commit
that referenced
this pull request
May 8, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes #2034
jayconrod
pushed a commit
that referenced
this pull request
May 8, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes #2034
jayconrod
pushed a commit
that referenced
this pull request
May 8, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes #2034
blico
pushed a commit
to blico/rules_go
that referenced
this pull request
May 10, 2019
Rewrite the files_equal_test() rules as a macro. The macro creates: - a sh_test, the actual test rule - a genrule that writes the source for the sh_test The old implementation was a Starlark test rule with a Bash script executable. Such a test cannot run on Windows with Bazel's Windows-native test wrapper, because the test wrapper cannot create a subprocess for .sh file, only for native binaries like an .exe file. The new implementation wraps the .sh file in a sh_test, which builds an .exe file on Windows. Bazel and the new native test wrapper can now run files_equal_test. [1] see bazelbuild/bazel#5508 and --incompatible_windows_native_test_wrapper Fixes bazel-contrib#2034
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite the files_equal_test() rules as a macro.
The macro creates:
The old implementation was a Starlark test rule
with a Bash script executable. Such a test cannot
run on Windows with Bazel's Windows-native test
wrapper, because the test wrapper cannot create a
subprocess for .sh file, only for native binaries
like an .exe file.
The new implementation wraps the .sh file in a
sh_test, which builds an .exe file on Windows.
Bazel and the new native test wrapper can now run
files_equal_test.
[1] see bazelbuild/bazel#5508
and --incompatible_windows_native_test_wrapper
Fixes #2034