Fix a race detected only if a test times out #3808
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe this can happen because the goroutine is started before the command is started. Start the process first, then on success, start the signal handler. Add a test for regression. I verified the test fails without my change to wrap.go and the race is from the signal handling goroutine.
|
@patrickmscott Thanks for catching this. Nevermind, this makes sense, I missed that we are accessing |
fmeum
reviewed
Jan 2, 2024
fmeum
approved these changes
Jan 2, 2024
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/bazel-starlib
Jan 3, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | patch | `v0.44.1` -> `v0.44.2` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.2`](https://github.com/bazelbuild/rules_go/releases/tag/v0.44.2) [Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.44.1...v0.44.2) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "7c76d6236b28ff695aa28cf35f95de317a9472fd1fb14ac797c9bf684f09b37c", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Make C++ toolchain optional by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3390](https://github.com/bazelbuild/rules_go/pull/3390) - Fix a race detected only if a test times out by [@​patrickmscott](https://github.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3808](https://github.com/bazelbuild/rules_go/pull/3808) - registering timeout handler synchronously by [@​linzhp](https://github.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3810](https://github.com/bazelbuild/rules_go/pull/3810) - patch release 0.44.2 by [@​tyler-french](https://github.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3811](https://github.com/bazelbuild/rules_go/pull/3811) **Full Changelog**: bazel-contrib/rules_go@v0.44.1...v0.44.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
renovate bot
referenced
this pull request
in kreempuff/rules_unreal_engine
Jan 3, 2024
[](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | patch | `v0.44.1` -> `v0.44.2` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.2`](https://github.com/bazelbuild/rules_go/releases/tag/v0.44.2) [Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.44.1...v0.44.2) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "7c76d6236b28ff695aa28cf35f95de317a9472fd1fb14ac797c9bf684f09b37c", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Make C++ toolchain optional by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3390](https://github.com/bazelbuild/rules_go/pull/3390) - Fix a race detected only if a test times out by [@​patrickmscott](https://github.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3808](https://github.com/bazelbuild/rules_go/pull/3808) - registering timeout handler synchronously by [@​linzhp](https://github.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3810](https://github.com/bazelbuild/rules_go/pull/3810) - patch release 0.44.2 by [@​tyler-french](https://github.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3811](https://github.com/bazelbuild/rules_go/pull/3811) **Full Changelog**: bazel-contrib/rules_go@v0.44.1...v0.44.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/kreempuff/rules_unreal_engine). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMDMuMSIsInVwZGF0ZWRJblZlciI6IjM3LjEwMy4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
](https://renovatebot.com){kind=link}
cgrindel-self-hosted-renovate bot
referenced
this pull request
in cgrindel/rules_swift_package_manager
Jan 7, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io_bazel_rules_go](https://github.com/bazelbuild/rules_go) | http_archive | patch | `v0.44.1` -> `v0.44.2` | --- ### Release Notes <details> <summary>bazelbuild/rules_go (io_bazel_rules_go)</summary> ### [`v0.44.2`](https://github.com/bazelbuild/rules_go/releases/tag/v0.44.2) [Compare Source](https://github.com/bazelbuild/rules_go/compare/v0.44.1...v0.44.2) #### `WORKSPACE` code load("@​bazel_tools//tools/build_defs/repo:http.bzl", "http_archive") http_archive( name = "io_bazel_rules_go", sha256 = "7c76d6236b28ff695aa28cf35f95de317a9472fd1fb14ac797c9bf684f09b37c", urls = [ "https://mirror.bazel.build/github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip", "https://github.com/bazelbuild/rules_go/releases/download/v0.44.2/rules_go-v0.44.2.zip", ], ) load("@​io_bazel_rules_go//go:deps.bzl", "go_register_toolchains", "go_rules_dependencies") go_rules_dependencies() go_register_toolchains(version = "1.21.5") #### What's Changed - Make C++ toolchain optional by [@​illicitonion](https://github.com/illicitonion) in [https://github.com/bazelbuild/rules_go/pull/3390](https://github.com/bazelbuild/rules_go/pull/3390) - Fix a race detected only if a test times out by [@​patrickmscott](https://github.com/patrickmscott) in [https://github.com/bazelbuild/rules_go/pull/3808](https://github.com/bazelbuild/rules_go/pull/3808) - registering timeout handler synchronously by [@​linzhp](https://github.com/linzhp) in [https://github.com/bazelbuild/rules_go/pull/3810](https://github.com/bazelbuild/rules_go/pull/3810) - patch release 0.44.2 by [@​tyler-french](https://github.com/tyler-french) in [https://github.com/bazelbuild/rules_go/pull/3811](https://github.com/bazelbuild/rules_go/pull/3811) **Full Changelog**: bazel-contrib/rules_go@v0.44.1...v0.44.2 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR is behind base branch, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi4xMDAuMCIsInVwZGF0ZWRJblZlciI6IjM2LjEwMC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9--> Co-authored-by: Self-hosted Renovate Bot <361546+cgrindel-self-hosted-renovate[bot]@users.noreply.github.enterprise.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe this can happen because the goroutine is started before the command is started. Start the process first, then on success, start the signal handler. Add a test for regression.
I verified the test fails without my change to wrap.go and the race is from the signal handling goroutine.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
It prevents a race detection when a test is timed out. We saw this a bunch and devs were really confused thinking there was a legit race detected.
Which issues(s) does this PR fix?
Fixes #
Other notes for review