Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup temp dirs in GoToolchainBinaryBuild #3885

Merged
merged 2 commits into from
Mar 11, 2024
Merged

Cleanup temp dirs in GoToolchainBinaryBuild #3885

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
254ca86
Cleanup temp dirs in GoToolchainBinaryBuild
hauserx Mar 11, 2024
fc5fbcd
Merge branch 'master' into remove_temp_files
hauserx Mar 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 16 additions & 7 deletions go/private/rules/binary.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -436,11 +436,20 @@ def _go_tool_binary_impl(ctx):

out = ctx.actions.declare_file(name)
if sdk.goos == "windows":
gopath = ctx.actions.declare_directory("gopath")
gocache = ctx.actions.declare_directory("gocache")
cmd = "@echo off\nset GOMAXPROCS=1\nset GOCACHE=%cd%\\{gocache}\nset GOPATH=%cd%\\{gopath}\n{go} build -o {out} -trimpath -ldflags \"{ldflags}\" {srcs}".format(
gopath = gopath.path,
gocache = gocache.path,
# Using pre-declared directory for temporary output as there is no safe
# way under Windows to create unique temporary dir.
gotmp = ctx.actions.declare_directory("gotmp")
cmd = """@echo off
set GOMAXPROCS=1
set GOCACHE=%cd%\\{gotmp}\\gocache
set GOPATH=%cd%"\\{gotmp}\\gopath
{go} build -o {out} -trimpath -ldflags \"{ldflags}\" {srcs}
set GO_EXIT_CODE=%ERRORLEVEL%
RMDIR /S /Q "{gotmp}"
MKDIR "{gotmp}"
exit /b %GO_EXIT_CODE%
""".format(
gotmp = gotmp.path.replace("/", "\\"),
go = sdk.go.path.replace("/", "\\"),
out = out.path,
srcs = " ".join([f.path for f in ctx.files.srcs]),
Expand All @@ -454,12 +463,12 @@ def _go_tool_binary_impl(ctx):
ctx.actions.run(
executable = bat,
inputs = sdk.headers + sdk.tools + sdk.srcs + ctx.files.srcs + [sdk.go],
outputs = [out, gopath, gocache],
outputs = [out, gotmp],
mnemonic = "GoToolchainBinaryBuild",
)
else:
# Note: GOPATH is needed for Go 1.16.
cmd = "GOMAXPROCS=1 GOCACHE=$(mktemp -d) GOPATH=$(mktemp -d) {go} build -o {out} -trimpath -ldflags '{ldflags}' {srcs}".format(
cmd = """GOTMP=$(mktemp -d);trap "rm -rf \"$GOTMP\"" EXIT;GOMAXPROCS=1 GOCACHE="$GOTMP"/gocache GOPATH="$GOTMP"/gopath {go} build -o {out} -trimpath -ldflags '{ldflags}' {srcs}""".format(
go = sdk.go.path,
out = out.path,
srcs = " ".join([f.path for f in ctx.files.srcs]),
Expand Down