Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to macos_arm64 #3990

Merged
merged 3 commits into from
Jul 18, 2024
Merged

Migrate to macos_arm64 #3990

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8c9de84
Migrate to macos_arm64
meteorcloudy Jul 18, 2024
be4d879
Add comment
meteorcloudy Jul 18, 2024
28030f4
Update bazel_testing.go
meteorcloudy Jul 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .bazelci/presubmit.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,7 +91,7 @@ tasks:
- "@go_default_sdk//..."
test_targets:
- "//..."
macos_legacy:
macos_arm64:
shell_commands:
- tests/core/cgo/generate_imported_dylib.sh
build_flags:
Expand Down
5 changes: 4 additions & 1 deletion go/tools/bazel_testing/bazel_testing.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,10 @@ func TestMain(m *testing.M, args Args) {
// hide that this code is executing inside a bazel test.
func BazelCmd(args ...string) *exec.Cmd {
cmd := exec.Command("bazel")
cmd.Args = append(cmd.Args, "--nosystem_rc", "--nohome_rc")
// --nosystem_rc isn't used here because Bazel may need essential flags set in
// system rc to be able to work correctly
// See https://github.com/bazelbuild/rules_go/pull/3969#issuecomment-2220405416
cmd.Args = append(cmd.Args, "--nohome_rc")
fmeum marked this conversation as resolved.
Show resolved Hide resolved
cmd.Args = append(cmd.Args, args...)
for _, e := range os.Environ() {
// Filter environment variables set by the bazel test wrapper script.
Expand Down