Remove orig_srcs #4038
Merged
Remove orig_srcs #4038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dzbarsky
force-pushed
the
zbarsky/orig-srcs
branch
2 times, most recently
from
52246ba to
3e2b05e
Compare
dzbarsky
commented
Aug 13, 2024
|
This has conflicts |
dzbarsky
force-pushed
the
zbarsky/orig-srcs
branch
from
3e2b05e to
c039ecc
Compare
Rebased! |
fmeum
force-pushed
the
zbarsky/orig-srcs
branch
from
7f6622b to
31c54d2
Compare
fmeum
force-pushed
the
zbarsky/orig-srcs
branch
from
31c54d2 to
f867cd3
Compare
fmeum
approved these changes
Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Starlark cleanup
What does this PR do? Why is it needed?
The documentation says it can differ from
srcs"if processing tools such as cgo or cover are applied." but in practice I did not see it mutating in the code; I suspect this may have been true in an earlier iteration of the rules. I also put in an assert in the provider creation code if they are different at the end and it didn't fire.Which issues(s) does this PR fix?
Fixes #
Other notes for review