Fix go_tool_binary
non-hermeticity and Go 1.19 incompatibility
#4167
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
go_tool_binary
used to non-hermetically pick up rules_go'sgo.mod
file when run unsandboxed, which resulted in it downloading a different toolchain and messing up version checks.Also make
nogo_main.go
compatible with Go 1.19 and test with nogo (which requires fixing a bunch of violations).Which issues(s) does this PR fix?
Fixes #
Other notes for review