Gazelle: sort srcs and deps string lists in buildifier order #613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a workaround for bazelbuild/buildtools#122. When buildifier sorts lists, it only processes list expressions as arguments for certain attributes. It doesn't process lists inside select or lists concatenated with select. When that bug is fixed, this code can be removed. Fixes bazel-contrib#584
|
I ran this version of Gazelle on Kubernetes, and it's starting to look pretty good. There are a lot of changes, but nearly all of them are reasonable now (e.g., moving platform specific files to |
ianthehat
approved these changes
Jul 10, 2017
| continue | ||
| } | ||
| bf.Walk(attr.Y, func(e bf.Expr, _ []bf.Expr) { | ||
| list, ok := e.(*bf.ListExpr) |
There was a problem hiding this comment.
I would probably have extracted this to a named function.
I don't think it's closing over any variables, so it's reasonably discrete, and I generally try to avoid long lambdas with return statements, it's really hard to see what the return will do.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a workaround for bazelbuild/buildtools#122. When buildifier
sorts lists, it only processes list expressions as arguments for
certain attributes. It doesn't process lists inside select or lists
concatenated with select. When that bug is fixed, this code can be
removed.
Fixes #584