Some suggested updates to the README #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
| @@ -90,6 +94,71 @@ They currently do not support (in order of importance): | |||
| ) | |||
| ``` | |||
|
|
|||
| * To depend on external libraries, you have two options: vendoring or external | |||
There was a problem hiding this comment.
This is a pretty long section for a README, but the information is useful.
I don't know what other projects do, but can a 'Vendoring.md' be created with this info and linked to?
There was a problem hiding this comment.
Sure, I'll do that now.
a discussion about how to use external libraries
|
Jenkins, please test this just in case. ... I hope the Jenkins integration works fine now. |
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @yugui, I tried to write down some of the instructions that I thought might have helped me when I first set out to use Go with Bazel. Are any of these worth pulling into the main repo?