Avoid involving a toolchain for the other build platform #72
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| _toolchain_map = { | ||
| 'linux': struct( | ||
| url = "https://storage.googleapis.com/golang/go1.7.linux-amd64.tar.gz", | ||
| sha256 = ("702ad90f705365227e902b42d91dd1a4" + |
There was a problem hiding this comment.
Can you put the whole sha256 on line line? I don't think there is a strict 80 char line limit on .bzl files and the ability to grep by the sha256 without having to remember that it is just the first 32 characters is something I personally enjoy having.
|
Nice patch, LGTM |
yugui
changed the title
Resolve a go toolchain for the build platform earlier because it does not make sense to download toolchains for other build platforms. * this makes it easier to support even more platform * this makes it easier to support locally installed toolchain, c.f. #46 * this prevents "bazel query" from forcing users to download a toolchain for the other platform
yugui
force-pushed
the
feature/single-gotool
branch
from
68237ee to
6fbe082
Compare
yugui
changed the title
| url = "https://storage.googleapis.com/golang/go1.7.linux-amd64.tar.gz", | ||
| sha256 = "702ad90f705365227e902b42d91dd1a40e48ca7f67a2f4b2fd052aaa4295cd95", | ||
| ), | ||
| 'mac os x': struct( |
There was a problem hiding this comment.
The bazel-standard name is "darwin", so maybe just use that?
There was a problem hiding this comment.
It must be consistent to ctx.os.name and it is actually "mac os x".
|
LGTM |
|
Jenkins, test this please. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve a go toolchain for the build platform earlier because it does not make sense to download toolchains for other build platforms.