Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Restore Target Uniqueness Guard in dependency_tree_parser.bzl (#1122)
I noticed the refactor of `dependency_tree_parser.bzl` in #994 might have unintentionally omitted a line that added target labels to the set of `seen_imports`. This line is present in [v5.3](https://github.com/bazelbuild/rules_jvm_external/blob/5.3/private/dependency_tree_parser.bzl#L155-L156), but then removed in [v6.1](https://github.com/bazelbuild/rules_jvm_external/blob/6.1/private/dependency_tree_parser.bzl#L457). I believe this removal was accidental, as it is now possible for `maven_install` to create a generated BUILD file which contains multiple copies of a target with the same name, which is an invalid state. This PR restores the missing call to `seen_imports[target_label] = True`.
- Loading branch information