Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Publish artifacts without additional classifiers #1011

Merged
merged 1 commit into from
Jan 2, 2024
Merged

fix: Publish artifacts without additional classifiers #1011

merged 1 commit into from
Jan 2, 2024

Conversation

bertschneider
Copy link
Contributor

Fix an ArrayIndexOutOfBoundsException when publishing an artifact without additional classifiers.

Exception in thread "main" java.lang.ArrayIndexOutOfBoundsException: Index 1 out of bounds for length 1
        at com.github.bazelbuild.rules_jvm_external.maven.MavenPublisher.main(MavenPublisher.java:109)

Fixes #1010

@bertschneider
fix: Publish artifacts without additional classifiers
e471ce2 
Fix array out of bounds exception when publishing an artifact without additional
classifiers.
shs96c
shs96c approved these changes Jan 2, 2024
View reviewed changes
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thank you :)

@shs96c shs96c merged commit 61e782a into bazel-contrib:master Jan 2, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shs96c shs96c shs96c approved these changes

@jin jin Awaiting requested review from jin jin is a code owner

@Wyverald Wyverald Awaiting requested review from Wyverald

@cheister cheister Awaiting requested review from cheister cheister is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Publish artifact without additional classifiers results in exception
2 participants
@bertschneider @shs96c