New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore Target Uniqueness Guard in dependency_tree_parser.bzl #1122

Merged

jin merged 1 commit into bazel-contrib:master from jonshea:dependency_tree_parser-seen_imports-fix

May 3, 2024

Commits on May 1, 2024

Restore Target Uniqueness Guard in dependency_tree_parser.bzl

I noticed the refactor of `dependency_tree_parser.bzl` in
bazel-contrib#994 might have
unintentionally omitted a line that added target labels to the set of
`seen_imports`. This line is present in
[v5.3](https://github.com/bazelbuild/rules_jvm_external/blob/5.3/private/dependency_tree_parser.bzl#L155-L156),
but then removed in
[v6.1](https://github.com/bazelbuild/rules_jvm_external/blob/6.1/private/dependency_tree_parser.bzl#L457).

I believe this removal was accidental, as it is now possible for
`maven_install` to create a generated BUILD file which contains
multiple copies of a target with the same name, which is an invalid
state.

This PR restores the missing call to `seen_imports[target_label] = True`.

jonshea committed May 1, 2024