Handle Bzlmod qualified repo names in coursier unpinned repo implementation #1203
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Under Bzlmod, repo names are qualified. Whereas a simple workspace with a single
@maven
repo would have before had an unpinned repo named@unpinned_maven
, nowthis repo is named something like
@rules_jvm_external~~maven~unpinned_maven
.Using
str.rpartition
by the~
delimiter enables us to consistentlyget the unqualified name in both cases:
After this change, the lockfile pinning script,
@maven//:pin
will use the localmachine's Coursier cache (
~/Library/Caches/Coursier
on MacOS) even underBzlmod. A populated cache makes version resolutions substantially faster to obtain.