Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

java_export to inherit testonly on its sub-targets #674

Merged
merged 1 commit into from
Mar 24, 2022

Conversation

tsawada
Copy link
Contributor

@tsawada tsawada commented Mar 24, 2022

I was trying to use maven_artifacts via java_export as suggested in #648, and noticed that -pom targets fail to build when they include testonly targets as deps.

I am not sure if this is a good way to resolve the issue (whether making pom target as testonly makes sense) though.

@tsawada
Copy link
Contributor Author

tsawada commented Mar 24, 2022

cc @dmivankov

@dmivankov
Copy link
Contributor

Makes sense to me: testonlywas already being passed (if it is set) from java_export via kwargs to java_library, this PR propagates it to other targets under in maven_export/java_export

Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense to me. Thank you for the PR!

@shs96c shs96c merged commit 20857b0 into bazel-contrib:master Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants