Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter java_export source jar based on deploy_env #767

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

fmeum
Copy link
Member

@fmeum fmeum commented Oct 12, 2022

The project jar has entries coming from the deploy_env filtered out. This commit ensures that the same filtering applies to source jars.

@fmeum fmeum marked this pull request as ready for review October 12, 2022 14:37
@fmeum fmeum requested a review from cheister as a code owner October 12, 2022 14:37
The project jar has entries coming from the deploy_env filtered out.
This commit ensures that the same filtering applies to source jars.
Copy link
Collaborator

@shs96c shs96c left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love the test. That helps a lot. Thank you!

LGTM

@shs96c shs96c merged commit f6cec9c into bazel-contrib:master Oct 12, 2022
@fmeum fmeum deleted the filter-deploy-env-srcs branch October 12, 2022 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants